feat: make the voxels shape use a sparse internal storage#380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the dedicated shapes for voxels uses a dense grid internally, meaning that even if the voxels
{0, 0, 0}and{1000, 1000, 1000}are set, the shape will allocate room for1000 * 1000 * 1000 = 1_000_000_000voxels (about 1GB) despite the fact that the shape is mostly empty.This PR replaces the internal dense grid by a sparse grid based on a hash-map combined with a
Bvh.Large maps that would exceed 4GB for some users are now down to about 1.3MB with this change.
Performance is mostly unchanged.