Fix tree shaking being too aggressive#289
Merged
ThierryBerger merged 4 commits intoJul 29, 2024
Merged
Conversation
sebcrozet
reviewed
Jul 26, 2024
Member
sebcrozet
left a comment
There was a problem hiding this comment.
Looking good. Can you please check if there is any package difference (with our compat and non-compat builds) with and without that change?
Rapier’s packages is already know for being quite big so I wouldn’t want to make it even bigger just to fit one bundler (in which case we would have to figure out a way to make this a special-case rather than apply to all the bundlers).
Contributor
Author
sebcrozet
approved these changes
Jul 26, 2024
Member
sebcrozet
left a comment
There was a problem hiding this comment.
Looking good, thanks. Ready to merge after the changelog is updated.
….js into fix-wasm-pack-side-effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix #278