Skip to content

Conversation

@gsakkis
Copy link
Contributor

@gsakkis gsakkis commented May 24, 2024

Update read_buffer_size parsing to Rows or Megabytes; currently neither works.

@adamchen
Copy link
Collaborator

Thanks for raising this, @gsakkis! I spent a bit of time wondering if there were a better way to specify MB vs rows, but given this is all coming from the sqla connection string I couldn't think of anything immediately obvious. I'll get this merged and built shortly.

@adamchen adamchen merged commit 8b34df0 into dirkjonker:master May 25, 2024
@gsakkis
Copy link
Contributor Author

gsakkis commented May 25, 2024

@adamchen many thanks for the quick update! It would be great if you cut a new release so I can install it from pypi instead of my fork!

@adamchen
Copy link
Collaborator

adamchen commented May 25, 2024 via email

@gsakkis
Copy link
Contributor Author

gsakkis commented May 25, 2024

Ah I was looking at the github releases, didn't realize it was already on pypi; thanks again!

@gsakkis gsakkis deleted the read_buffer_size branch May 25, 2024 20:01
@adamchen
Copy link
Collaborator

Ah, sorry - thanks for the nudge! I've updated that too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants