503 Fix Sample Tree Issues #504
Conversation
Test Results 3 files 3 suites 40m 43s ⏱️ Results for commit 6096e73. ♻️ This comment has been updated with latest results. |
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Interestingly your CI is failing on one of the OSX builds because of stray quote marks in the Gudrun source. I had the exact same thing on a Linux machine somewhere very recently and had to manually go and remove them (there are a couple of them)... migiht be something we need to address as a general issue.
gudpy/gui/widgets/core/gudpy_tree.py
Outdated
| return False | ||
| elif role == Qt.CheckStateRole and self.isSample(index): | ||
| if value == Qt.Checked: | ||
| if value == 2: |
There was a problem hiding this comment.
Aside from the fact that magic numbers like this are bad, I'm not sure I understand what's being checked for here.
There was a problem hiding this comment.
To check whether the check box is checked or unchecked
The issue is caused due to the github workflow update, amended in #506 |
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
I think I'd already approved this, but I'll approve it again!
Closes #503
Fixes current issues with GudPy tree name checking, enabling/disabling samples and related bugs.