Accept both client ID and application ID URI as valid audiences#249
Merged
Accept both client ID and application ID URI as valid audiences#249
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MCP server’s Entra JWT audience validation to accept access tokens whose aud claim is either the Application ID URI (e.g. api://task-wizard) or the app registration’s Client ID GUID—matching how VS Code’s MCP client requests tokens.
Changes:
- Read
TW_ENTRA_CLIENT_IDat startup and validate it is set. - Switch JWT validation from
ValidAudiencetoValidAudiencesto allow both the configured audience and client ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VS Code's MCP client acquires tokens from Entra using the app registration's Client ID as the resource identifier, so Entra stamps that GUID as the
audclaim. The MCP server only acceptedapi://task-wizard(the Application ID URI), causing all requests to fail with:Fix
TW_ENTRA_CLIENT_IDenvironment variableValidAudiencetoValidAudiencesaccepting bothapi://<app-name>and the Client ID GUID