Skip to content

Fix CalDAV discovery for RFC 6764 compliance#250

Merged
dkhalife merged 2 commits intomainfrom
rfc6764
Mar 21, 2026
Merged

Fix CalDAV discovery for RFC 6764 compliance#250
dkhalife merged 2 commits intomainfrom
rfc6764

Conversation

@dkhalife
Copy link
Owner

  • Add /.well-known/caldav endpoint (301 redirect to /dav/tasks/)
  • Add auth middleware to root PROPFIND/REPORT so unauthenticated requests get 401 + WWW-Authenticate instead of 403
  • Extract auth middleware into reusable variable

Copilot AI review requested due to automatic review settings March 21, 2026 05:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go API server’s CalDAV routing to improve RFC 6764 discovery behavior and authentication responses for CalDAV clients.

Changes:

  • Added /.well-known/caldav to redirect clients to the CalDAV collection at /dav/tasks/.
  • Applied the auth middleware to root PROPFIND/REPORT requests to / (previously handled without auth middleware).
  • Extracted auth.MiddlewareFunc() into a reusable authMiddleware variable for consistent use across routes.

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apiserver/internal/apis/caldav.go 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dkhalife dkhalife merged commit a88c39c into main Mar 21, 2026
6 of 7 checks passed
@dkhalife dkhalife deleted the rfc6764 branch March 21, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants