Skip to content

Conversation

@scaronni
Copy link
Member

Print only once when there's something fishy with the modules when running dkms status. Also, change the output slightly to avoid a double warning and be consistent with capital letters, style, etc.

Example before this change, when removing a kernel without uninstalling the DKMS modules:

# dkms status
nvidia/565.57.01, 6.11.10-300.fc41.x86_64, x86_64: installed
nvidia/565.57.01, 6.12.1-400.vanilla.fc41.x86_64, x86_64: installed (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!)
xone/0.3^20240425git29ec357, 6.11.10-300.fc41.x86_64, x86_64: installed
xone/0.3^20240425git29ec357, 6.12.1-400.vanilla.fc41.x86_64, x86_64: installed (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!) (WARNING! Missing some built modules!)
xpadneo/0.9.6^20241101gitbe65dbb, 6.11.10-300.fc41.x86_64, x86_64: installed
xpadneo/0.9.6^20241101gitbe65dbb, 6.12.1-400.vanilla.fc41.x86_64, x86_64: installed (WARNING! Missing some built modules!)

After:

# dkms status
nvidia/565.57.01, 6.11.10-300.fc41.x86_64, x86_64: installed
nvidia/565.57.01, 6.12.1-400.vanilla.fc41.x86_64, x86_64: installed (Built modules are missing in the kernel modules folder)
xone/0.3^20240425git29ec357, 6.11.10-300.fc41.x86_64, x86_64: installed
xone/0.3^20240425git29ec357, 6.12.1-400.vanilla.fc41.x86_64, x86_64: installed (Built modules are missing in the kernel modules folder)
xpadneo/0.9.6^20241101gitbe65dbb, 6.11.10-300.fc41.x86_64, x86_64: installed
xpadneo/0.9.6^20241101gitbe65dbb, 6.12.1-400.vanilla.fc41.x86_64, x86_64: installed (Built modules are missing in the kernel modules folder)

@scaronni scaronni requested a review from amilonenv November 29, 2024 13:20
@scaronni scaronni marked this pull request as draft November 29, 2024 21:35
@scaronni scaronni marked this pull request as ready for review November 29, 2024 23:19
@scaronni scaronni requested a review from zeroepoch November 29, 2024 23:35
@scaronni scaronni merged commit 3c36d9b into master Nov 30, 2024
56 checks passed
@scaronni scaronni deleted the fixes branch November 30, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants