Skip to content

Conversation

@anbe42
Copy link
Collaborator

@anbe42 anbe42 commented Jan 22, 2025

some reordering and enhancements for the testsuite

There are some more in the queue, but I need some CI changes for that but I have not enough experience with the github CI to fix that myself properly ...

I'm about to add some tests for dkms_autoinstaller (and maybe dkms_common.postinst later too) but that doesn't work on the CI since it only runs make install which skips these. It would need to run make install_debian or make install_redhat as appropriate for the current platform ...

(Actually I wanted to file this as a separate issue, but for some reason that didn't work ...)

@anbe42
Copy link
Collaborator Author

anbe42 commented Jan 22, 2025

(Actually I wanted to file this as a separate issue, but for some reason that didn't work ...)

Creating issues works with Ctrl+Return, but not with clicking on the button ...

@scaronni
Copy link
Member

I'm about to add some tests for dkms_autoinstaller (and maybe dkms_common.postinst later too) but that doesn't work on the CI since it only runs make install which skips these. It would need to run make install_debian or make install_redhat as appropriate for the current platform ...

I'll take care of this.

@scaronni
Copy link
Member

@anbe42 #482

@anbe42 anbe42 force-pushed the autoinstall-tests branch from 97e2318 to 000efbf Compare January 23, 2025 17:24
@anbe42
Copy link
Collaborator Author

anbe42 commented Jan 23, 2025

I rebased this PR on your tests branch, interleaved the previously omitted dkms_autoinstaller tests, tested and verified that they actually get executed.

I have a few more changes in the Debian package that should get upstreamed. I'll dig them out tomorrow and thereafter time should be right for a new release.

anbe42 added 25 commits January 24, 2025 10:45
there is no /etc/sysconfig/ on Debian (or derivatives)
map any autoinstall error to 1 for a lsb compliant exit code
@anbe42 anbe42 force-pushed the autoinstall-tests branch from b90501f to ffc58ac Compare January 24, 2025 09:53
@scaronni scaronni merged commit d07034f into dkms-project:master Jan 28, 2025
25 checks passed
@anbe42 anbe42 deleted the autoinstall-tests branch February 5, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants