Skip to content

Various fixes for weak modules and SUSE #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scaronni merged 4 commits into from
Jan 30, 2025
Merged

Various fixes for weak modules and SUSE #486

scaronni merged 4 commits into from
Jan 30, 2025

Conversation

@scaronni
Copy link
Member

@scaronni scaronni commented Jan 30, 2025 •
edited
Loading

  • Fix variable check when determining if NO_WEAK_MODULES is set to trigger the whole weak module process.
  • kABI is available only on SUSE and RHEL platforms, so avoid setting parameters for all other distributions.
  • For SUSE, use the new script provided in suse-module-tools and not the one provided by suse-module-tools-legacy.
  • Avoid issues with output being redirected when invoking DKMS via RPM scriptlet on SUSE platforms.
  • Avoid issues of processes not getting killed on SUSE platforms.
  • When deleting a kernel, also delete multiple original modules (collisions folder).

@scaronni scaronni force-pushed the fixes branch 2 times, most recently from cfe8b5d to db9ed59 Compare January 30, 2025 11:16
@scaronni scaronni requested a review from amilonenv January 30, 2025 12:31
@scaronni scaronni force-pushed the fixes branch 2 times, most recently from d72e8d6 to 6bf6007 Compare January 30, 2025 12:45
@scaronni
Rework weak modules logic
43fae20 
- Fix variable check when determining if NO_WEAK_MODULES is set.
- kABI is available only on SUSE and RHEL platforms, so avoid setting parameters
  for all other distributions.
- For SUSE, use the new script provided in suse-module-tools and not the
  one provided by suse-module-tools-legacy.
@scaronni scaronni merged commit d2a142a into master Jan 30, 2025
50 checks passed
@scaronni scaronni deleted the fixes branch January 30, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amilonenv amilonenv amilonenv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scaronni @amilonenv