Skip to content

Attempts for fixing #488 #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scaronni merged 1 commit into from
Feb 13, 2025
Merged

Attempts for fixing #488 #493

scaronni merged 1 commit into from
Feb 13, 2025

Conversation

@scaronni
Copy link
Member

@scaronni scaronni commented Feb 12, 2025 •
edited
Loading

Tracking changes here for the above

@scaronni scaronni marked this pull request as draft February 12, 2025 15:15
@scaronni scaronni mentioned this pull request Feb 12, 2025
Closed
@anbe42
Copy link
Collaborator

anbe42 commented Feb 12, 2025

I would probably revert #490 and replace the stray || continue with || return 1 instead

@scaronni
Copy link
Member Author

scaronni commented Feb 12, 2025

I would probably revert #490 and replace the stray || continue with || return 1 instead

Ok!

@scaronni
Copy link
Member Author

scaronni commented Feb 12, 2025

Done.

@scaronni scaronni marked this pull request as ready for review February 13, 2025 15:14
@scaronni
Copy link
Member Author

scaronni commented Feb 13, 2025

@anbe42 please review, I think we can merge and close, based on last feedback in #488

@scaronni scaronni merged commit 831ab3b into master Feb 13, 2025
50 checks passed
@scaronni scaronni deleted the continue branch March 1, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anbe42 anbe42 anbe42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scaronni @anbe42