Add post_transaction command #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Definitely open to rename The failures in the pipelines are unrelated to this, I'll make a separate Pull Request to fix them. |
Member
Author
|
@anbe42 @amilonenv @zeroepoch opinions? Besides my use cases, I see the opportunity for removing lots of code in most DKMS packages. |
zeroepoch
reviewed
Apr 23, 2025
xuzhen
reviewed
Apr 23, 2025
scaronni
force-pushed
the
post-action
branch
19 times, most recently
from
597924b to
364e224
Compare
zeroepoch
approved these changes
Apr 25, 2025
Member
Author
|
I'm ready this one, waiting a bit more if anyone has anything to add |
xuzhen
requested changes
Apr 25, 2025
xuzhen
reviewed
Apr 25, 2025
scaronni
force-pushed
the
post-action
branch
6 times, most recently
from
5a25a28 to
c6cb871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a generic command that gets executed at the end of "install/uninstall" phases for modules. The
post_transactionis configured in/etc/dkms/framework.confand if set to any non-null value the command in there is executed with the kernel version that is the target of the command as the first parameter.This can be set on a per-site or by distribution packagers of DKMS.
It's executed only at the end of commands that change the content of the kernel modules folder; so an
install,autoinstallandremove|unbuild|uninstallcommand. When the directive is not set (the default) there is no behavior change for DKMS.The action generates a log in the DKMS working directory using the facilities already provided by DKMS.
This originates from a need in NVIDIA for various components, (restarting services, recreating the
initrd, etc.) but judging from a few Debian and Ubuntu packages I checked, this could remove all thepostinstscripts that take care of callingupdate-initramfs, for example: https://salsa.debian.org/broadcom-sta-team/broadcom-sta/-/blob/debian/6.30.223.271-26/debian/broadcom-sta-common.postinst?ref_type=tags