Skip to content

Conversation

@reckart
Copy link
Member

@reckart reckart commented Jan 31, 2023

  • Post-process merged type system to ensure internal consistency
  • Unit test checking for consistency of merged type system
  • Auto-format

- Post-process merged type system to ensure internal consistency
- Unit test checking for consistency of merged type system
- Auto-format
@reckart reckart added this to the 0.7.4 milestone Jan 31, 2023
@reckart reckart self-assigned this Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #273 (fe07469) into main (832b8c1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   95.35%   95.38%   +0.03%     
==========================================
  Files           5        5              
  Lines        1872     1887      +15     
==========================================
+ Hits         1785     1800      +15     
  Misses         87       87              
Impacted Files Coverage Δ
cassis/json.py 91.72% <100.00%> (+0.11%) ⬆️
cassis/typesystem.py 95.43% <100.00%> (+0.07%) ⬆️
cassis/xmi.py 96.72% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jcklie jcklie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@reckart reckart merged commit 06b2f0e into main Jan 31, 2023
@reckart reckart deleted the bugfix/270-Merging-type-systems-breaks-consistency branch January 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants