#276 - Cannot deserialize from JSON Cas if child type comes before super type #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jcklie
commented
Feb 9, 2023
jcklie
commented
- Add is_predefined helper
- Use toposort to fix the bug
…per type - Make JSON serializing more deterministic by sorting type system by name
…per type - Use toposort when deserializing JSON type systems
Codecov Report
@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 95.39% 95.36% -0.04%
==========================================
Files 5 5
Lines 1888 1897 +9
==========================================
+ Hits 1801 1809 +8
- Misses 87 88 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jcklie
deleted the
bugfix/276-json-deserialize-child-type-before-supertype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.