Conversation
Msara index
connected stylesheet to html ugh
Group object constructor
Group object constructor
Styling mai
…e reservation pages.
Style suggestion page
edited some wording
deleted dinnerApp.js
Delete files
Pulling dev branch into master before uploading to gh-pages
| }); | ||
| }; | ||
|
|
||
| // start filtering meal type locations IF CLICKED. saving for now just in case |
There was a problem hiding this comment.
it's still best to omit commented code from the master branch. You can always keep it on a feature branch and copy it from there to master if you want to un-comment it.
| // ^ end filtering click event for meal types ^ | ||
|
|
||
| //helper function to create table elements | ||
| function makeAnElementWithText(element, textContent, parent) { |
There was a problem hiding this comment.
makeAnElementWithText, setClassOfAddressCells, and makeAReservationButton could all be handled by a single function. you could pass the attribute and attribute value as arguments, and just use defaults or an if/else to set no attribute for elements that don't need it.
| makeAnElementWithText('th', 'Meal', rowEl); | ||
| tableEl.appendChild(rowEl); | ||
| for (var i = 0; i < allLocations.length; i++) { | ||
| createRow('foodTable', 'tr', 'td', allLocations[i].name, allLocations[i].hood, allLocations[i].address, allLocations[i].restrictions, allLocations[i].mealType); |
There was a problem hiding this comment.
so many arguments! why not createRow('foodTable', 'tr', 'td', allLocations[i] here and above,
function createRow(idName, rowElement, El, location) { ... makeAnElementWithText(El, tC1, location.name); ...
| makeReservationEventListeners(); | ||
| showAddressMarker(); | ||
| var tableEl = document.getElementById('foodTable'); | ||
| var tableCells = tableEl.getElementsByTagName('td'); |
There was a problem hiding this comment.
might be easier to hide/show whole s rather than individual cells for filtering
| @@ -0,0 +1,195 @@ | |||
| 'use strict'; | |||
| @@ -0,0 +1,36 @@ | |||
| var breakfastLocationData = [ | |||
| {'name': 'Millionaire Club Charity Breakfast', 'hood': 'Belltown', 'address': '2515 Western Ave', 'meal': 'breakfast', 'days': [1, 2, 3, 4, 5], 'openTime': 6, 'closeTime': 7, 'restrictions': 'none'}, | |||
There was a problem hiding this comment.
it should be possible to flatten this data into one array of locations. there's a lot of duplicate information like name, address, hood for locations that have multiple meals. what if each location object had breakfast, lunch and dinner properties that were either null or breakfast: { days: [1,2,3], openTime: 6, closeTime: 7, restrictions: 'none' }.
| var address = event.target.address.value; | ||
| var days = [ ]; | ||
| var displayDays = [ ]; | ||
| var mondayStatus = function() { |
There was a problem hiding this comment.
might be cleaner to put all of these [day]Status functions in one big function since they always get called together. That could also allow you to use a loop to check each day, since the only things that change from one day to another are the selector, the value to push, and the display name. Could be an object like {selector, value, displayName}
4 participants
No description provided.