Fix deprecations

[wilzbach]

They were getting annoying ;-)

[PetarKirov]

I think the following may be shorter/faster:

auto filterChars(string chars, S)(S str)
{
	import std.algorithm.comparison : among;
    import std.algorithm.iteration : filter;
    import std.meta : aliasSeqOf;
	return str.filter!(c => !c.among(aliasSeqOf!chars));
}

if (!token.text.filterChars!"Ll".to!double)
    // ...

[PetarKirov]

Aprart from my suggestion, LGTM.

[wilzbach]

I think the following may be shorter/faster:

Yes, that's very elegant!

[PetarKirov]

(Don't mind my stupid ws commits, I'll squash them out of existance as soon as the tests pass ;) )

[wilzbach]

(Don't mind my stupid ws commits, I'll squash them out of existance as soon as the tests pass ;) )

No worries, I also made the same mistake here. Setting up a .editorconfig plugin in your favorite IDE can really help ;-)
Btw don't mind the test failure on dmd-nightly for now - it's a known regression in EMSI containers.

[PetarKirov]

No worries, I also made the same mistake here. Setting up a .editorconfig plugin in your favorite IDE can really help ;-)

Ah yes, I have done so ages ago, but sometimes I'm too lazy and I edit PRs with the GitHub online editor.

Btw don't mind the test failure on dmd-nightly for now - it's a known regression in EMSI containers.

I noticed, but I can't make sense of the error - I don't think it should be there. Anyway, I think we should also bring emsi_containers to the org, so we can more easily manage such issues.

[wilzbach]

I noticed, but I can't make sense of the error - I don't think it should be there.

It was introduced here: dlang/dmd#6816

Anyway, I think we should also bring emsi_containers to the org, so we can more easily manage such issues.

That's a great idea -> https://github.com/economicmodeling/containers/issues/81