Skip to content

Fixes cases of false or non positive with the useless init check #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
11 commits merged into from
Jun 28, 2017
Merged

Fixes cases of false or non positive with the useless init check #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1ed66d
fix #474 fix #473 fix #476 - Cases of false and non positive with the…
Jun 22, 2017
191a694
do not warn on documented variables
Jun 22, 2017
ea70c61
fix #477 - Custom type initialized to init should not trigger a warn
Jun 22, 2017
5d41fd9
allow struct.init when know struct has `@disable` ctor
Jun 23, 2017
133e3b9
fix last false detection in phobos
Jun 23, 2017
12c92b7
prevent check in the "compiles" trait
Jun 23, 2017
b37b398
- use canFind when filter.empty was negated
Jun 25, 2017
7d01a74
fix, self-linting missed a case that was not yet fixed
Jun 25, 2017
7ef6c4b
fix more undetected warns during self linting
Jun 25, 2017
49dbb33
use a flag instead of a stack + apply skipTests
Jun 28, 2017
e9b792a
convert spaces to tabs
Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/analysis/base.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public:

protected:

bool inAggregate = false;
bool inAggregate;
Copy link
Contributor

@skl131313 skl131313 Jun 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a tab here instead of spaces, even before the change. Might be a good idea to setup some code guidelines and checks for them, not sure if there were any before.

Copy link
Author

@ghost ghost Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure there's one. @Hackerpilot uses tabs on his stuff. Excepted libdparse because it was planned to be included in phobos.

Copy link
Collaborator

@Hackerpilot Hackerpilot Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .editorconfig file for this project does specify tabs.

bool skipTests;

template visitTemplate(T)
Expand Down
12 changes: 6 additions & 6 deletions src/analysis/duplicate_attribute.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ class DuplicateAttributeCheck : BaseAnalyzer

void checkAttributes(const Declaration node)
{
bool hasProperty = false;
bool hasSafe = false;
bool hasTrusted = false;
bool hasSystem = false;
bool hasPure = false;
bool hasNoThrow = false;
bool hasProperty;
bool hasSafe;
bool hasTrusted;
bool hasSystem;
bool hasPure;
bool hasNoThrow;

// Check the attributes
foreach (attribute; node.attributes)
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/enumarrayliteral.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class EnumArrayLiteralCheck : BaseAnalyzer
super(fileName, sc, skipTests);
}

bool looking = false;
bool looking;

mixin visitTemplate!ClassDeclaration;
mixin visitTemplate!InterfaceDeclaration;
Expand Down
4 changes: 2 additions & 2 deletions src/analysis/function_attributes.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ class FunctionAttributeCheck : BaseAnalyzer
{
if (dec.parameters.parameters.length == 0)
{
bool foundConst = false;
bool foundProperty = false;
bool foundConst;
bool foundProperty;
foreach (attribute; dec.attributes)
foundConst = foundConst || attribute.attribute.type == tok!"const"
|| attribute.attribute.type == tok!"immutable"
Expand Down
1 change: 0 additions & 1 deletion src/analysis/line_length.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ private:
size_t length;
const newLine = tok.line > prevLine;
bool multiLine;

if (tok.text is null)
length += str(tok.type).length;
else
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/objectconst.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class ObjectConstCheck : BaseAnalyzer
|| name == "toString" || name == "opCast";
}

private bool looking = false;
private bool looking;

}

Expand Down
6 changes: 3 additions & 3 deletions src/analysis/opequals_without_tohash.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ class OpEqualsWithoutToHashCheck : BaseAnalyzer

private void actualCheck(const Token name, const StructBody structBody)
{
bool hasOpEquals = false;
bool hasToHash = false;
bool hasOpCmp = false;
bool hasOpEquals;
bool hasToHash;
bool hasOpCmp;

// Just return if missing children
if (!structBody || !structBody.declarations || name is Token.init)
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/run.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ void generateReport(string[] fileNames, const StaticAnalysisConfig config,
bool analyze(string[] fileNames, const StaticAnalysisConfig config,
ref StringCache cache, ref ModuleCache moduleCache, bool staticAnalyze = true)
{
bool hasErrors = false;
bool hasErrors;
foreach (fileName; fileNames)
{
auto code = readFile(fileName);
Expand Down
8 changes: 4 additions & 4 deletions src/analysis/undocumented.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ class UndocumentedDeclarationCheck : BaseAnalyzer
immutable bool prevOverride = getOverride();
immutable bool prevDisabled = getDisabled();
immutable bool prevDeprecated = getDeprecated();
bool dis = false;
bool dep = false;
bool ovr = false;
bool pushed = false;
bool dis;
bool dep;
bool ovr;
bool pushed;
foreach (attribute; dec.attributes)
{
if (isProtection(attribute.attribute.type))
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/unmodified.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ private:
castExpression.accept(this);
}

bool foundCast = false;
bool foundCast;
}

if (initializer is null)
Expand Down
Loading