More consistent error messages, always use backticks for literals #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 7 7
Lines 4623 4623
=======================================
Hits 3786 3786
Misses 837 837
Continue to review full report at Codecov.
|
wilzbach
approved these changes
Dec 21, 2017
Member
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
LGTM. I also created a style guide to document this for future contributors & added it as first point.
https://github.com/dlang-community/libdparse/wiki/Style-guide
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes literals inside message were enclosed between single quotes, sometimes between double quotes. Now are always used backticks.