Fix #204 - add dfmt to the tour#516
Conversation
|
Depends on dlang-community/dfmt#281 - otherwise DUB will fail as it tries to build |
|
Ah, just at had a look at Travis... so the problems that I was getting locally shouldn't surprise me. My guess is that there's something wrong with the dub description of dfmt. AFAIK, most users use |
As mentioned that's due to |
Thanks a lot! |
public/static/js/tour-controller.js
Outdated
| 'Ctrl-R': function(cm) { | ||
| $scope.$apply('reset()'); | ||
| }, | ||
| 'Ctrl-F': function(cm) { |
There was a problem hiding this comment.
Ctrl-F is not a good choice, because on most GUI application on Windows and Linux it maps to "Find in page"
There was a problem hiding this comment.
Can you map it to Ctrl+Alt+F?
There was a problem hiding this comment.
Okay, on a first attempt cfp hotkeys and the codemirror hotkeys didn't seem to support this, but "ALT-F" worked fine.
Btw there seems to be non-universal combination for formatting anyways, so I guess we are quite free in picking one, e.g:
- IntelliJ: Ctrl+Alt+L.
- Eclipse: Ctrl + Shift + F
- Visual studio is entirely different.
Sure, I'll do some more local testing & review and then will do accordingly. When testing locally with dfmt~master, I wasn't able the formatting to work - even pressing the button did nothing. I'll investigate further tomorrow, cuz now I've got to go. |
|
@ZombineDev: FYI this is green now |
|
@ZombineDev as I figured out how to do manual deploys, I will merge this now as it works perfectly fine on my local machine and I now have some time to watch the deploys... |
2 participants
A very simple integration of
dfmt.