Skip to content

Comments

Disable ariovistus/pyd#330

Merged
dlang-bot merged 1 commit intodlang:masterfrom
Geod24:disable-pyd
Oct 30, 2018
Merged

Disable ariovistus/pyd#330
dlang-bot merged 1 commit intodlang:masterfrom
Geod24:disable-pyd

Conversation

@Geod24
Copy link
Member

@Geod24 Geod24 commented Oct 30, 2018

The repository switched to a docker-based testsuite:
ariovistus/pyd@e21dde4

CC @ariovistus

The repository switched to a docker-based testsuite:
ariovistus/pyd@e21dde4
@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @Geod24! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@Geod24 Geod24 requested a review from wilzbach October 30, 2018 05:14
@Geod24
Copy link
Member Author

Geod24 commented Oct 30, 2018

Auto-merging to unblock other repos

@dlang-bot dlang-bot merged commit 8c87df4 into dlang:master Oct 30, 2018
@Geod24 Geod24 deleted the disable-pyd branch October 30, 2018 05:28
@ariovistus
Copy link

well, this is the first I've heard of this project building pyd. I'll try to get into build kite later, but for the moment, I don't know how stuff works in this project or what's failing. Is it just using test scripts from my .travis.yml?

@MartinNowak
Copy link
Member

Thanks for getting back @ariovistus. We're running the project tester against a couple of often used dub packages to prevent regressions during development of dlang.
Your benefit in participating is a higher protection of your project against dlang regressions.

Is it just using test scripts from my .travis.yml?

Yes, that's what it tries to do, though we have a couple of overrides for some projects.
Do you think it would be possile to continue using the non-docker based test script?
Would it make sense to keep it alongside your Travis-CI docker tests as well?

@ariovistus
Copy link

I can bring back the old .travis.yml and keep it somewhere in my repo, if that would be suitable. Also, is this project just testing against dmd builds, or does it test multiple compilers?

@PetarKirov
Copy link
Member

PetarKirov commented Nov 8, 2018

@ariovistus buildkite tests each pull request to dmd, druntime, phobos and dub against the latest tags of many dub packages such as yours. See https://forum.dlang.org/thread/vytpearrfgxqfqugtaow@forum.dlang.org for more info. So essentially it tests unreleased versions of dmd 99% of the time. Keeping your project compilable with latest released version of dmd is all that's required from your side.

@MartinNowak what would adding support for docker and other container runtimes entail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants