Skip to content

Comments

Start testing Sociomantic ocean in pipeline#87

Closed
mihails-strasuns wants to merge 1 commit intodlang:masterfrom
mihails-strasuns:test-ocean
Closed

Start testing Sociomantic ocean in pipeline#87
mihails-strasuns wants to merge 1 commit intodlang:masterfrom
mihails-strasuns:test-ocean

Conversation

@mihails-strasuns
Copy link
Contributor

Recently (sociomantic-tsunami/ocean#321) we have enabled CI testing with vanilla upstream DMD compiler for WIP ocean major branch, as 2.077 provided necessary Throwable.message().

Would appreciate getting it to the list of automatically tested projects ;)

Only problem I see is that it depends on https://github.com/sociomantic-tsunami/d1to2fix - we normally provide it via https://hub.docker.com/r/sociomantictsunami/dlang but current Jenkins setup doesn't support docker containers AFAIR.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @mihails-strasuns! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

sh 'git submodule update --init'
sh 'make d2conv' // requires d1to2fix installed
sh 'make test DVER=2 F=production'
break;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just download and make d1to2fix here then for the time being ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I plan to download d1to2fix and libebtree debian packages from our bintray repos and extract required binaries. Just haven't got to update this PR yet.

@mihails-strasuns
Copy link
Contributor Author

Updated, but getting some weird github plugin error now:

Could not update commit status. Message: Server returned HTTP response code: 201, message: 'Created' for URL: https://api.github.com/repos/dlang/ci/statuses/b6f1906dd982604876a4c1948e443976e8cfe01a

Does that ring a bell for anyone?

@nemanja-boric-sociomantic

Yes, I had this previously and I had to update GitHub plugin on my Jenkins installation.

@nemanja-boric-sociomantic

v1.90 was enough

@nemanja-boric-sociomantic

I think this was the issue: hub4j/github-api#387

@mihails-strasuns
Copy link
Contributor Author

CC @MartinNowak

@leandro-lucarella-sociomantic

Is @MartinNowak the only one that can merge and enable this? We would really love to see this happening so we can make sure our D2 migration can continue smoothly with respect to upstream from now on :)

@PetarKirov
Copy link
Member

@CyberShadow @wilzbach I think you guys also have write access here. Can we move forward with this pull request?

@PetarKirov
Copy link
Member

But we first need to update the GitHub plugin, as @nemanja-boric-sociomantic suggests. Can we do this in this PR?

@mihails-strasuns
Copy link
Contributor Author

mihails-strasuns commented Nov 19, 2017

Can we do this in this PR?

I don't think so, that requires administrative access to Jenkins instance (including restarting the service).

@PetarKirov
Copy link
Member

I see, hopefully @MartinNowak would be able to take a look soon.

@wilzbach
Copy link
Contributor

I think you guys also have write access here.

Yeah, but I don't have any admin rights for the server on which Jenkins is installed or the Jenkins instance itself, so I can't help here atm :/

@mihails-strasuns
Copy link
Contributor Author

Closing in favor of #88 to avoid being administratively blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants