Skip to content

Comments

use Travis-CI command to test ocean#90

Closed
MartinNowak wants to merge 1 commit intodlang:masterfrom
MartinNowak:beaver_test
Closed

use Travis-CI command to test ocean#90
MartinNowak wants to merge 1 commit intodlang:masterfrom
MartinNowak:beaver_test

Conversation

@MartinNowak
Copy link
Member

  • also add beaver to PATH

- also add beaver to PATH
@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @MartinNowak!

@mihails-strasuns
Copy link
Contributor

beaver is a shell utility on top of docker, haven't you mentioned that you don't want to use it for now?

@MartinNowak
Copy link
Member Author

I see, read this

To use Docker in you builds, Beaver expects a Dockerfile

as optional docker support.

@mihails-strasuns
Copy link
Contributor

mihails-strasuns commented Nov 29, 2017

No, sorry for the misleading wording. Maybe @leandro-lucarella-sociomantic originally intended it may work both ways thus put it into readme like that, but right now it is tightly tied to docker.

@leandro-lucarella-sociomantic

Yeah, even when beaver is not really tied to docker, I think at the moment all tools use docker. If we are not calling beaver from the build scripts, then there is no point in adding beaver to the path.

Also, I don't know what test_travis_yaml() is for, but our travis build uses docker, so if docker is not available here, you probably want to ignore the travis.yml file too.

@MartinNowak
Copy link
Member Author

test_travis_yaml()

Just executes the script of a .travis.yml, but nothing else.

@MartinNowak MartinNowak closed this Dec 1, 2017
@MartinNowak MartinNowak deleted the beaver_test branch December 1, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants