Skip to content

Comments

Temporarily disable problematic ocean test#91

Merged
MartinNowak merged 1 commit intodlang:masterfrom
mihails-strasuns:disable-ocean-test
Nov 30, 2017
Merged

Temporarily disable problematic ocean test#91
MartinNowak merged 1 commit intodlang:masterfrom
mihails-strasuns:disable-ocean-test

Conversation

@mihails-strasuns
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @mihails-strasuns! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.


case 'sociomantic-tsunami/ocean':
sh '''
echo '\nTEST_FILTER_OUT += $C/test/collectd/main.d' >> Build.mak

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong test ;-). Should be test/sysstats/main.d.

@mihails-strasuns
Copy link
Contributor Author

Green

@MartinNowak MartinNowak merged commit fcce587 into dlang:master Nov 30, 2017
@MartinNowak
Copy link
Member

Think I found the culprit for the random test failures, sociomantic-tsunami/ocean#389.

@nemanja-boric-sociomantic

#88 (comment) :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants