Open
Conversation
Member
|
Unfortunately this change causes multiple race conditions. I think when we make an attempt to parallelize document generation, we should also use pure and shared/immutable within the affected call tree to let the compiler make reasonably sure that the approach is correct. Frankly, I don't feel comfortable to do multi-threading these days without either that or guaranteed memory isolation, unless it is a small and isolated piece of code. Too many bad memories from C++ times ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently dpl-docs on dlang.org run a single-thread. That makes them the bottleneck in time consumption.