Skip to content

Comments

Fix tests on DMD master#240

Merged
s-ludwig merged 10 commits intomasterfrom
fix-dmd-master
Oct 17, 2025
Merged

Fix tests on DMD master#240
s-ludwig merged 10 commits intomasterfrom
fix-dmd-master

Conversation

@s-ludwig
Copy link
Member

No description provided.

@WebFreak001
Copy link
Member

looks like just formatting changes in the diff that were making it fail like:

2025-09-20T10:46:03.0290349Z + git --no-pager diff --exit-code -- docs
2025-09-20T10:46:03.0314108Z diff --git a/tests/issue110_xref_to_package_d/docs/mod.html b/tests/issue110_xref_to_package_d/docs/mod.html
2025-09-20T10:46:03.0314974Z index ee82c62..ece5a25 100644
2025-09-20T10:46:03.0315432Z --- a/tests/issue110_xref_to_package_d/docs/mod.html
2025-09-20T10:46:03.0316013Z +++ b/tests/issue110_xref_to_package_d/docs/mod.html
2025-09-20T10:46:03.0316555Z @@ -40,8 +40,7 @@ $('#symbolSearchPane').show();</script>
2025-09-20T10:46:03.0317019Z  			</ul>
2025-09-20T10:46:03.0317294Z  		</nav>
2025-09-20T10:46:03.0317578Z  		<div id="main-contents">
2025-09-20T10:46:03.0318194Z -			<h1>Module mod</h1><p></p>
2025-09-20T10:46:03.0318639Z -			<section></section>
2025-09-20T10:46:03.0319043Z +			<h1>Module mod</h1><p></p><section></section>
2025-09-20T10:46:03.0319513Z  			<footer>
2025-09-20T10:46:03.0319841Z  				<table class="license-info">
2025-09-20T10:46:03.0320255Z  					<tr>
2025-09-20T10:46:03.0321052Z diff --git a/tests/issue110_xref_to_package_d/docs/mod/foo.html b/tests/issue110_xref_to_package_d/docs/mod/foo.html
2025-09-20T10:46:03.0322144Z index fe61d7e..2f877d8 100644
2025-09-20T10:46:03.0322629Z --- a/tests/issue110_xref_to_package_d/docs/mod/foo.html
2025-09-20T10:46:03.0323244Z +++ b/tests/issue110_xref_to_package_d/docs/mod/foo.html
2025-09-20T10:46:03.0323825Z @@ -40,8 +40,7 @@ $('#symbolSearchPane').show();</script>
2025-09-20T10:46:03.0324270Z  			</ul>
2025-09-20T10:46:03.0324547Z  		</nav>
2025-09-20T10:46:03.0324856Z  		<div id="main-contents">
2025-09-20T10:46:03.0325240Z -			<h1>Module mod.foo</h1><p></p>
2025-09-20T10:46:03.0325636Z -			<section></section>
2025-09-20T10:46:03.0326021Z +			<h1>Module mod.foo</h1><p></p><section></section>
2025-09-20T10:46:03.0326433Z  			<footer>
2025-09-20T10:46:03.0326723Z  				<table class="license-info">
2025-09-20T10:46:03.0327064Z  					<tr>
2025-09-20T10:46:03.0329444Z diff --git a/tests/issue110_xref_to_package_d/docs/test.html b/tests/issue110_xref_to_package_d/docs/test.html
2025-09-20T10:46:03.0330231Z index ce392fd..fe14aa1 100644
2025-09-20T10:46:03.0330658Z --- a/tests/issue110_xref_to_package_d/docs/test.html
2025-09-20T10:46:03.0331188Z +++ b/tests/issue110_xref_to_package_d/docs/test.html
2025-09-20T10:46:03.0331708Z @@ -40,8 +40,7 @@ $('#symbolSearchPane').show();</script>
2025-09-20T10:46:03.0332471Z  			</ul>
2025-09-20T10:46:03.0332711Z  		</nav>
2025-09-20T10:46:03.0332973Z  		<div id="main-contents">
2025-09-20T10:46:03.0333314Z -			<h1>Module test</h1><p></p>
2025-09-20T10:46:03.0333666Z -			<section></section>
2025-09-20T10:46:03.0334020Z +			<h1>Module test</h1><p></p><section></section>
2025-09-20T10:46:03.0334446Z  			<section>
2025-09-20T10:46:03.0334718Z  				<h2>Functions</h2>
2025-09-20T10:46:03.0335022Z  				<table>
2025-09-20T10:46:03.0335750Z diff --git a/tests/issue110_xref_to_package_d/docs/test/foo.html b/tests/issue110_xref_to_package_d/docs/test/foo.html
2025-09-20T10:46:03.0336662Z index 8ab38a0..ec9cd29 100644
2025-09-20T10:46:03.0337095Z --- a/tests/issue110_xref_to_package_d/docs/test/foo.html
2025-09-20T10:46:03.0337637Z +++ b/tests/issue110_xref_to_package_d/docs/test/foo.html
2025-09-20T10:46:03.0338161Z @@ -44,13 +44,11 @@ $('#symbolSearchPane').show();</script>
2025-09-20T10:46:03.0338583Z  </p>
2025-09-20T10:46:03.0338841Z  			<div class="prototype">
2025-09-20T10:46:03.0339174Z  				<code class="lang-d">
2025-09-20T10:46:03.0339515Z -					<div class="single-prototype">
2025-09-20T10:46:03.0340340Z -			<span class="typ">void</span> <span class="pln">foo</span><span class="pun">(</span><span class="pun">)</span><span class="pun">;</span>
2025-09-20T10:46:03.0341712Z +					<div class="single-prototype"><span class="typ">void</span> <span class="pln">foo</span><span class="pun">(</span><span class="pun">)</span><span class="pun">;</span>
2025-09-20T10:46:03.0342836Z  					</div>
2025-09-20T10:46:03.0343095Z  				</code>
2025-09-20T10:46:03.0343345Z  			</div>
2025-09-20T10:46:03.0343585Z  			
2025-09-20T10:46:03.0343899Z -			
2025-09-20T10:46:03.0344135Z  			<footer>
2025-09-20T10:46:03.0344407Z  				<table class="license-info">
2025-09-20T10:46:03.0344769Z  					<tr>
2025-09-20T10:46:03.0380106Z + echo 'FAILED: HTML generation test failed: tests/issue110_xref_to_package_d'
2025-09-20T10:46:03.0380708Z + failure=1
2025-09-20T10:46:03.0380973Z + popd
2025-09-20T10:46:03.0381246Z + for dir in tests/*
2025-09-20T10:46:03.0381598Z + pushd tests/issue116_inherit_macros
2025-09-20T10:46:03.0382326Z FAILED: HTML generation test failed: tests/issue110_xref_to_package_d

@s-ludwig s-ludwig marked this pull request as ready for review October 15, 2025 07:58
@s-ludwig
Copy link
Member Author

Okay, DMD now finally succeeds with the updated formatting. However, LDC/Linux is running into the known memory corruption issue for one of the tests (#255, vibe-d/vibed.org#70). We should probably still merge this and allow development to continue with these errors present, as long as it hasn't been narrowed down.

@s-ludwig
Copy link
Member Author

Narrowed it down to libdparse/DLexer and it turns out this is already fixed for libdparse 0.25.0.

@s-ludwig s-ludwig requested a review from WebFreak001 October 17, 2025 06:34
@s-ludwig s-ludwig merged commit 0b96ed1 into master Oct 17, 2025
6 checks passed
@s-ludwig s-ludwig deleted the fix-dmd-master branch October 17, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants