Merged
Conversation
Member
|
LGTM |
Member
|
LGTM too |
dstyle.dd
Outdated
| $(LI Selective imports should have a space before and after the colon (`:`) like | ||
| `import std.range : zip`) | ||
| $(LI Local, selective imports should be preferred over global imports) | ||
| $(LI In $(I non-templated) functions should be annotated with matching attributes (`@nogc`, `@safe`, `pure`, `nothrow`)) |
Member
There was a problem hiding this comment.
In non-templated functions, WHAT should be annotated? Did you mean to not add "In"?
wilzbach
force-pushed
the
improve_style_guide
branch
from
c137875 to
a13bb50
Compare
Contributor
Author
|
@CyberShadow I tried to address your comments. Overall I think that some of these points don't only apply for Phobos, but are part of the "D Style" in general, e.g. local selective imports or the section about attributes). |
Contributor
|
✅ |
Contributor
Author
|
Does this need approval from W/A? (It's blocking dlang/phobos#4585 a bit) |
Contributor
Author
|
Ping - it's still blocking dlang/phobos#4585 ;-) |
Contributor
|
Nobody objected, and I see nothing controversial. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion at #4585, here a couple of items that are part of the "unofficial" Phobos style guide, but probably should be documented.
CC @DmitryOlshansky