Skip to content

Add a small writing style guide#1448

Merged
AndrejMitrovic merged 1 commit intodlang:masterfrom
wilzbach:patch-2
Aug 28, 2016
Merged

Add a small writing style guide#1448
AndrejMitrovic merged 1 commit intodlang:masterfrom
wilzbach:patch-2

Conversation

@wilzbach
Copy link
Contributor

As proposed on #1401, here's a proposal for a small writing guide to clarify common rules for contributors.

CC @AndrejMitrovic

@dlang-bot
Copy link
Contributor

@wilzbach, thanks for your PR! By analyzing the annotation information on this pull request, we identified @quickfur and @zachthemystic to be potential reviewers. @quickfur: The PR was automatically assigned to you, please reassign it if you were identified mistakenly.

(The DLang Bot is under development. If you experience any issues, please open an issue at its repo.)

@wilzbach wilzbach mentioned this pull request Aug 28, 2016
* Use a _neutral_ tone (No strong narrator = no first-person ("I", "we") nor second-person ("you"))
* Use a _formal_ style (No slang)
* Use the [American English spelling](https://en.wikipedia.org/wiki/American_and_British_English_spelling_differences)
* Use the [Oxford comma](https://en.wikipedia.org/wiki/Serial_comma) for coordinating conjunctions (C, C++__,__ and D)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me again what are the double underscores about?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are emphasizing the comma. :) All good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are emphasizing the comma. :) All good.

Yep ;-)
For the future: GitHub also allows to directly preview Markdown. Just click on the "View" link (top right).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it confused me is because I thought I was looking at a ddoc file. 😄

@AndrejMitrovic
Copy link
Contributor

LGTM.

@AndrejMitrovic AndrejMitrovic merged commit 2e49dbe into dlang:master Aug 28, 2016
@wilzbach wilzbach deleted the patch-2 branch August 28, 2016 16:43
@CyberShadow
Copy link
Member

CyberShadow commented Aug 28, 2016

I feel like this has gotten in way too quickly.

  1. I think this needs broader consensus.
  2. As I argued on the similar Phobos PR, we actively need to avoid stuffing CONTRIBUTING.md with trivia. GitHub tells people to read this file before people submit changes, so this should only contain things that people need to read before submitting changes. Just because someone somewhere one time submitted a PR that would've been avoided had he read the entirety of our guidelines does not make a case to burden all contributors with more guidelines that they must read.

I think this should be reverted. Feel free to put this on the wiki on a linkable page, though.

@andralex ?

@andralex
Copy link
Member

Yah this doesn't quite add a lot of value yet. It would be useful to initiate it as a wiki page and merge it when it gets more significant.

@dnadlinger
Copy link
Contributor

@CyberShadow: From that perspective (the link on PR/issue creation), the whole file should be scrapped, though, and replaced with a short bullet list of important things to consider (links to style, our processes, …).

@AndrejMitrovic
Copy link
Contributor

Ok we could move it to the wiki. I'll revert it for now.

@CyberShadow
Copy link
Member

@CyberShadow: From that perspective (the link on PR/issue creation), the whole file should be scrapped, though, and replaced with a short bullet list of important things to consider (links to style, our processes, …).

Yep, that's just what I said here: dlang/phobos#4585 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants