Set comma expression deprecation release and implicit string concatenation#1487
Merged
AndrejMitrovic merged 2 commits intodlang:masterfrom Oct 24, 2016
Merged
Conversation
Contributor
|
mathias-lang-sociomantic
changed the title
Contributor
Author
|
The DMD P.R. was merged 🎉 |
Contributor
Author
|
Pingity ping |
Contributor
|
Is the build failure unrelated to the PR, can we merge regardless? |
deprecate.dd
Outdated
| to spot bugs, for example:) | ||
|
|
||
| --- | ||
| string[] arr = [ "Hello", "buggy" "World" ]; |
Contributor
There was a problem hiding this comment.
I'd use a more realistic example. The classic mistake is made when the list of strings is separated on each line:
string[] names =
[
"Anna",
"Michael"
"Emma",
"David"
];
Contributor
Ah all pulls are failing, nevermind me. |
mathias-lang-sociomantic
force-pushed
the
fix-3827
branch
from
6c82674 to
ab8ef46
Compare
Contributor
Author
|
Updated, sorry for the delay |
deprecate.dd
Outdated
| string foo = "Hello" "World"; | ||
| --- | ||
|
|
||
| This feature is handy for long string that spans multiple lines, |
Contributor
|
Can you fix the missing |
Contributor
Author
|
Fixed |
mathias-lang-sociomantic
force-pushed
the
fix-3827
branch
from
ab8ef46 to
aed8547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not merge until dlang/dmd#6155 is merged.