Skip to content

Comments

more changelog work for 2.072.0#1498

Merged
MartinNowak merged 9 commits intodlang:stablefrom
MartinNowak:changelog
Oct 15, 2016
Merged

more changelog work for 2.072.0#1498
MartinNowak merged 9 commits intodlang:stablefrom
MartinNowak:changelog

Conversation

@MartinNowak
Copy link
Member

No description provided.

@MartinNowak MartinNowak changed the title add druntime changelog more changelog work for 2.072.0 Oct 14, 2016
Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits

$(BUGSTITLE Compiler Changes,
$(LI $(RELATIVE_LINK2 deferred_alias, Analysis for aliases in imported modules is deferred.))
$(LI $(RELATIVE_LINK2 iteration_closure, OpApply now conservatively allocates a closure unless marked `scope`))
$(LI $(RELATIVE_LINK2 dash_safe, Add -transition=safe switch to enable additional @safe checks.))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safe in backticks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps -transition=safe goes in backticks, too

$(LI $(RELATIVE_LINK2 drt-oncycle, New druntime switch `--DRT-oncycle`
allows specifying what to do on cycle detection in modules.))
$(LI $(RELATIVE_LINK2 gc-runtimeswitch-added, A switch for selecting
the GC implementation at runtime was added.))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the switch name be mentioned?

$(P Implicit concatenation of string literal is a very early feature that is now supplanted
by the concatenation operator ('~'), the later being more explicit.)

$(P It could result in hard to spot bug, where one missed a coma in an array expression:)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/coma/comma/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/bug/bugs/

void foo ()
{
string[] arr = [ "Hello", "buggy" "World" ];
assert(arr.length = 3); // Fail, the length of the array is 2 and the content is [ "Hello", "buggyWorld" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/=/==/


$(BUGSTITLE Compiler Changes,
$(LI $(LNAME2 deferred_alias, Analysis for aliases in imported modules is deferred.)
$(LI $(LNAME2 iteration_closure, OpApply now conservatively allocates a closure unless marked `scope`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: opApply, also put in backquotes


$(LI
$(LNAME2 native_tls_osx, Native TLS on OS X 64 bit.)
$(LI $(LNAME2 dash_safe, Add -transition=safe switch to enable additional @safe checks.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-transition=safe and @safe in backquoutes


$(LI $(LNAME2 drt-oncycle, New druntime switch `--DRT-oncycle` allows
specifying what to do on cycle detection in modules.)
$(P When module cycles are detected, the default behavior is to print the cycle, and abort execution. However, in many cases, the cycles are not harmful. With the new `--DRT-oncycle` switch, you can effect a different behavior when cycles are detected:)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superlong line

@MartinNowak MartinNowak merged commit 4627049 into dlang:stable Oct 15, 2016
@MartinNowak MartinNowak deleted the changelog branch October 15, 2016 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants