Skip to content

Comments

[changelog] Refine comma expression examples#1502

Merged
andralex merged 1 commit intodlang:masterfrom
ntrel:comma-examples
Nov 2, 2016
Merged

[changelog] Refine comma expression examples#1502
andralex merged 1 commit intodlang:masterfrom
ntrel:comma-examples

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Oct 23, 2016

  • Remove cruft, make clearer.
  • Add link to comma bug examples.

Original PR: dlang/dmd#5737

@ntrel ntrel changed the title [2.072 changelog] Refine comma expression examples [changelog] Refine comma expression examples Oct 30, 2016
$(P Comma expressions expressions have proven to be a frequent source of confusion, and bug.
Using their result will now trigger a deprecation message.)
$(P Comma expressions have proven to be a frequent source of confusion, and bugs -
see $(LINK2 https://issues.dlang.org/show_bug.cgi?id=2659#c2, here) for examples.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use HTTPS instead of LINK2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use HTTPS instead of LINK2

Or don't. HTTPS doesn't buy us anything. This is getting old. I'm a little disappointed that you just keep pushing for it, @andralex, seemingly without reason. (previously)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simple reason is it's shorter. I've written a bunch of documentation and it helps. Please let's not argue on something this petty - just (preferably) do it or don't. I've approved the PR already so this is advisory. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simple reason is it's shorter.

The simple reason for LINK2 is that you can copy/paste from the browser. I think this wins.

Please let's not argue on something this petty - just (preferably) do it or don't. I've approved the PR already so this is advisory. Thanks.

Sure. If you stop nagging people about using HTTP/HTTPS instead of LINK2, you won't have to read my nagging anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simple reason for LINK2 is that you can copy/paste from the browser. I think this wins.

I understand. It seems otherwise to me. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andralex I think all of myself, @aG0aep6G, @wilzbach and anyone with an opinion agrees that HTTPS and such are harmful and should be replaced. An argument I haven't seen mentioned is that with LINK2 etc. the link appears as it is in the source code in the same way as it will be in HTML and the browser URL. With HTTP/HTTPS it's no longer an URL, but some macro cacophony that we have created. This makes e.g. grepping for links harder. There is also the semantic issue that it moves the URL protocol, which is part of the URL (a self-contained reference to something) into a macro (which we use semantics for), thus it moves information across a boundary that should be left alone. The 6-7 characters saved in exchange make a poor contrary position, considering the length of typical URLs. As such, I recommend dropping this argument and converting the HTTP/HTTPS macros to LINK2 or whatever whenever convenient.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure what you meant by "The simple reason is it's shorter. I've written a bunch of documentation and it helps.", as URLs should never be typed, only copied. As such, removing the protocol and turning it into a macro actually creates more work than leaving the URL intact.

@ntrel
Copy link
Contributor Author

ntrel commented Nov 2, 2016

Changed to use HTTPS, rebased. Sorry for the delay ;-)

@andralex andralex merged commit bbb9bb0 into dlang:master Nov 2, 2016
@MartinNowak
Copy link
Member

Mmpf, changes to the changelog should go into the stable branch so they are reflected in point releases.

MartinNowak pushed a commit that referenced this pull request Nov 8, 2016
[changelog] Refine comma expression examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants