Skip to content

Deprecation: set .sort and .reverse props are 'Error' starting with 2.075#1672

Merged
andralex merged 1 commit intodlang:masterfrom
wilzbach:sort-reverse-error
Jun 6, 2017
Merged

Deprecation: set .sort and .reverse props are 'Error' starting with 2.075#1672
andralex merged 1 commit intodlang:masterfrom
wilzbach:sort-reverse-error

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 6, 2017

Copy link
Member

@UplinkCoder UplinkCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andralex andralex merged commit 40a2ba3 into dlang:master Jun 6, 2017
@CyberShadow
Copy link
Member

Kind of a nitpick, but I think the "error" column is for explicit errors given when the compiler explicitly detects the use of the deprecated feature. AIUI these properties were removed outright, so it would be more correct to leave the "error" column blank, like what was done with clear below in the table.

@UplinkCoder
Copy link
Member

UplinkCoder commented Jun 7, 2017 via email

@CyberShadow
Copy link
Member

well together with the removal comes an error when they are used.

If you apply that logic, then that makes the error column completely useless, because if a feature is completely removed from the compiler code, of course you're going to get some error or another when trying to use it.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jun 7, 2017

well together with the removal comes an error when they are used.

Hehe, that was my logic as well.

then that makes the error column completely useless, because if a feature is completely removed from the compiler code, of course you're going to get some error or another when trying to use it.

That's a fair point:
#1680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants