Skip to content

Temporarily fix the example roulette#1767

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:temporarily-fix-example-roulette
Jun 25, 2017
Merged

Temporarily fix the example roulette#1767
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:temporarily-fix-example-roulette

Conversation

@wilzbach
Copy link
Contributor

From #1757 (comment)

OK, so, as I understand, this PR does three things right now:
Fix the JS roulette
IMO these should be separate PRs, or at least commits

Well #1757 removes this bit completely (hence no separate commit), but as the discussion seems to take a bit longer, there's no reason why we couldn't fix the roulette in the meantime.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

CyberShadow commented Jun 25, 2017

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Shouldn't this have been the brief version? You have push access here.

@wilzbach
Copy link
Contributor Author

Shouldn't this have been the brief version? You have push access here.

The GH API lists only 30 items per requests (e.g. https://api.github.com/orgs/dlang/public_members), and as it mostly affects only me (https://api.github.com/orgs/dlang/public_members?page=2) I was too lazy/busy too fix it for now.

@CyberShadow
Copy link
Member

How about checking if https://api.github.com/repos/dlang/dlang.org/commits?author=wilzbach is non-empty? Then contributors would also start getting the shorter message once their first PR is accepted.

@CyberShadow
Copy link
Member

The GH API lists only 30 items per requests

?per_page=100 but either way that solution doesn't scale.

}
----
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML diff says:

- 
+) 

so this doesn't seem right.

@wilzbach
Copy link
Contributor Author

How about checking if https://api.github.com/repos/dlang/dlang.org/commits?author=wilzbach is non-empty? Then contributors would also start getting the shorter message once their first PR is accepted.

-> let's continue this discussion over at the bot: dlang/dlang-bot#94

@dlang-bot dlang-bot merged commit 82f523d into dlang:master Jun 25, 2017
@wilzbach wilzbach deleted the temporarily-fix-example-roulette branch June 26, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants