Temporarily fix the example roulette#1767
Conversation
|
Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Shouldn't this have been the brief version? You have push access here. |
The GH API lists only 30 items per requests (e.g. https://api.github.com/orgs/dlang/public_members), and as it mostly affects only me (https://api.github.com/orgs/dlang/public_members?page=2) I was too lazy/busy too fix it for now. |
|
How about checking if https://api.github.com/repos/dlang/dlang.org/commits?author=wilzbach is non-empty? Then contributors would also start getting the shorter message once their first PR is accepted. |
?per_page=100 but either way that solution doesn't scale. |
| } | ||
| ---- | ||
| ) | ||
| ) |
There was a problem hiding this comment.
HTML diff says:
-
+) so this doesn't seem right.
b178147 to
b78d9aa
Compare
-> let's continue this discussion over at the bot: dlang/dlang-bot#94 |
From #1757 (comment)
Well #1757 removes this bit completely (hence no separate commit), but as the discussion seems to take a bit longer, there's no reason why we couldn't fix the roulette in the meantime.