Insert the actual ddoc file containing predefined macros instead of d…#1805
Insert the actual ddoc file containing predefined macros instead of d…#1805andralex merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @andralex! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Duplicate of #1703 ? |
|
Looks like a superset. I'd say we either pull this, or remove the content from the doc page and replace it with a link to the actual file. |
|
I think an earlier version of #1703 did pretty much what this does, but not the current diff. |
|
Btw if we go with #1688, we could easily insert the exact file from DMD here and avoid it getting outdated in the future. |
|
Push this and close #1703? |
|
Rebased. Let's take action on this soon lest it's liable to rot every time something changes in the ddoc default - which is what it's supposed to :) |
|
It doesn't preclude a more radical approach a la #1688 but it does make progress while we mull over that. |
|
Essentially I don't think we should put that huge DDoc template in our specs. It's huge, likely to change (as it's stylistic in nature), and overshadows the definitions that one might actually look at. I've said this before, and IMO the default DDoc template change wasn't done as well as it could have. The built-in definitions should have stayed unchanged; instead, the compiler could the include an additional |
spec/ddoc.src.dd
Outdated
| ESCAPES = /$(LT)/$(AMP)lt;/ | ||
| /$(GT)/$(AMP)gt;/ | ||
| /$(AMP)/$(AMP)amp;/ | ||
| 3fc0f638fb1ab1bad2e01f507b968324 |
There was a problem hiding this comment.
Where is this coming from? A Git hash or a random set of characters?
There was a problem hiding this comment.
I generated it with mcookie. The idea is it's a unique string to be replaced with the actual text.
…plementation-defined
|
I agree that the default macro definitions should be implementation-defined. I've reworked this diff to mention that, and also added the idea in #1703 to it. |
Good call. LGTM. |
5 participants
…uplicating it
Automation FTW.