Convert "Const, Immutable and Shared" to a SECTION2#2044
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jan 2, 2018
Merged
Convert "Const, Immutable and Shared" to a SECTION2#2044dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
andralex
reviewed
Jan 2, 2018
spec/class.dd
Outdated
| where $(I Identifier) is the name generated for the anonymous nested class. | ||
|
|
||
| $(SECTION3 $(LEGACY_LNAME2 ConstClass, const-class, Const, Immutable and Shared Classes), | ||
| $(SECTION2 $(LEGACY_LNAME2 ConstClass, const-class, Const, Immutable and Shared Classes), |
Member
There was a problem hiding this comment.
The doc is weird, only shows "Const". I think you need: $(SECTION2 $(LEGACY_LNAME2 ConstClass, const-class, $(ARGS Const, Immutable and Shared Classes)),
Contributor
Author
Yeah this is still a small issue with the TOC generator, but that's unrelated to this PR.
|
Member
|
@wilzbach I figure but can you please do both improvements here? it's quick and easy. |
Contributor
Author
Done. |
andralex
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: http://dtest.dlang.io/artifact/website-e6672ddd5f4efc6e60942fd38836a7bb2abc1361-6511322dd0ebeb894df6eea5bc0109e9/web/spec/class.html
From #2043