Skip to content

Correct unittest point: with -> without#2117

Merged
dlang-bot merged 1 commit intodlang:masterfrom
mathias-baumann-sociomantic:patch-1
Jan 25, 2018
Merged

Correct unittest point: with -> without#2117
dlang-bot merged 1 commit intodlang:masterfrom
mathias-baumann-sociomantic:patch-1

Conversation

@mathias-baumann-sociomantic
Copy link
Contributor

I suspect that's what was intended?

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @mathias-baumann-sociomantic! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@schveiguy
Copy link
Member

The grammar doesn't make sense, even before the change. I'm not sure what the statement in parentheses is trying to say. Can you explain what it means?

@schveiguy
Copy link
Member

ping @wilzbach as the original author.

@schveiguy
Copy link
Member

OK, I think it came from this comment: #1796 (comment)

So yes, the intent is to say, you can unit test your betterC functions by running without -betterC.

@wilzbach
Copy link
Contributor

I suspect that's what was intended?

Yes, thanks.

Can you explain what it means?

The point was to say that unittest doesn't work with -betterC, but for testing purposes the program can simply compiled and run without -betterC.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@schveiguy
Copy link
Member

Suggestion (correct grammar, and removing superfluous "as usual"): "testing can be done without the -betterC flag"

@wilzbach
Copy link
Contributor

Suggestion (correct grammar, and removing superfluous "as usual"): "testing can be done without the -betterC flag"

I changed it to your suggestion. Thanks!

@dlang-bot dlang-bot merged commit 4e07e9f into dlang:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants