Fix building dlang.org from scratch by wilzbach · Pull Request #2340 · dlang/dlang.org

wilzbach · 2018-04-13T12:20:24Z

See: https://forum.dlang.org/post/azdfcrfqegubikcyntfj@forum.dlang.org

The problem was that GIT_HOME was undefined and thus the git clone failed.
I think we should really have a CI for this. @CyberShadow what do you think about re-enabling Travis?

I also added a hint about DIFFABLE=1 to the docs while I was at it.

dlang-bot · 2018-04-13T12:20:26Z

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach · 2018-04-13T12:24:01Z

.travis.yml

-  - make -f posix.mak test
+  - make -f posix.mak html
+  - make -f posix.mak clean && rm -rf ../{dmd,druntime,phobos,tools,installer,dub}
+  - make -f posix.mak all


I thought we should test the two most important targets: html and all

wilzbach · 2018-04-13T12:24:26Z

posix.mak

+GIT_HOME=https://github.com/dlang

 # Auto-cloning missing directories
 $(shell [ ! -d $(DMD_DIR) ] && git clone --depth=1 ${GIT_HOME}/dmd $(DMD_DIR))


Now GIT_HOME is no longer undefined and checking out /dmd doesn't fail.

wilzbach · 2018-04-13T12:24:51Z

posix.mak

 # Clone all main D repositories
 ${DMD_DIR} ${DRUNTIME_DIR} ${PHOBOS_DIR} ${TOOLS_DIR} ${INSTALLER_DIR} ${DUB_DIR}:
-	git clone ${GIT_HOME}/$(notdir $(@F)) $@
+	git clone --depth=1 ${GIT_HOME}/$(notdir $(@F)) $@


It takes quite a long time to do a full checkout of dmd and it isn't really required.

Git history is needed for git describe to work properly, so this might not be a good idea.

wilzbach · 2018-04-13T12:26:13Z

posix.mak


 changelog/prerelease.dd: $G/changelog/next-version $(LOOSE_CHANGELOG_FILES) | \
-							${STABLE_DMD} $(TOOLS_DIR) $(INSTALLER_DIR) $(DUB_DIR)
+							${STABLE_DMD} $(DMD_DIR) $(DRUNTIME_DIR) $(PHOBOS_DIR) $(TOOLS_DIR) $(INSTALLER_DIR) $(DUB_DIR)


druntime and phobos weren't cloned by default for the changelog script anymore.

CyberShadow · 2018-04-13T12:49:41Z

posix.mak

 # Clone all main D repositories
 ${DMD_DIR} ${DRUNTIME_DIR} ${PHOBOS_DIR} ${TOOLS_DIR} ${INSTALLER_DIR} ${DUB_DIR}:
-	git clone ${GIT_HOME}/$(notdir $(@F)) $@
+	git clone --depth=1 ${GIT_HOME}/$(notdir $(@F)) $@


Git history is needed for git describe to work properly, so this might not be a good idea.

CyberShadow · 2018-04-13T12:52:40Z

CONTRIBUTING.md

+
+The dlang.org build process depends on many files which are downloaded during
+the build process. If you happen to have a slow internet connection, you can skip
+these downloads with `DIFFABLE=`:


How true is this really?

CyberShadow · 2018-04-13T12:53:00Z

CONTRIBUTING.md

 ended with error code 0, directory `web` contains the produced HTML
 files. Take a moment to open `web/index.html` in a browser.

+### Building without changing files


"without changing files" is kind of ambiguous here

CyberShadow · 2018-04-13T12:53:46Z

CONTRIBUTING.md


 Please see the [Ddoc fundamentals](https://wiki.dlang.org/Contributing_to_dlang.org).
+
+### Learn about the more Makefile targets and options


This doesn't sound right. s/the // ?

CyberShadow · 2018-04-13T12:56:19Z

@CyberShadow what do you think about re-enabling Travis?

Why was it disabled?

I don't know if it's going to bring enough benefit vs. the overhead of managing another CI. I guess we could try and see if it doesn't get in the way too much?

zachthemystic · 2018-04-14T05:14:22Z

I just tried "make -f posix.mak all" again. It still fails for me, after:"
CC="c++" /tmp/.host_dmd-2.072.2/dmd2/osx/bin/dmd -conf=/tmp/.host_dmd-2.072.2/dmd2/osx/bin/dmd.conf -of../generated/osx/release/64/dmd -m64 -vtls -J../generated/osx/release/64 -J../res -L-lstdc++ -version=MARS -fPIC -w -de dmd/access.d .....
.......................(Long list of files).................
sed -i -e "s|../druntime/import |../druntime-2.079.0/import |" -e "s|../phobos |../phobos-2.079.0 |" .generated/dmd-2.079.0/generated/osx/release/64/dmd.conf
sed: -e: No such file or directory
make: *** [.generated/dmd-2.079.0/generated/osx/release/64/dmd] Error 1
make: *** Deleting file `.generated/dmd-2.079.0/generated/osx/release/64/dmd'
"

CyberShadow · 2018-04-14T10:53:32Z

Looks like your sed isn't GNU sed.

zachthemystic · 2018-04-14T12:37:39Z

Looks like your sed isn't GNU sed.

This link might help:
https://stackoverflow.com/questions/2320564/i-need-my-sed-i-command-for-in-place-editing-to-work-with-both-gnu-sed-and-bsd

wilzbach · 2018-04-14T21:48:46Z

Why was it disabled?

I think because we moved the testsuite to DAutoTest to keep the CI overhead low here.

I don't know if it's going to bring enough benefit vs. the overhead of managing another CI. I guess we could try and see if it doesn't get in the way too much?

Ok enabled. Ideally it should just work "out of the box" (as for any fresh checkout).

Looks like your sed isn't GNU sed.

Ok. I added a "Posix-compatible" way with using a temporary file. Not sure why we need to build this compiler anyhow, Maybe we can even remove the dependence on this entirely, but for now "... && mv" should work.

zachthemystic · 2018-04-16T14:48:54Z

Build failed. But at least we know that it ran for 15 minutes and 50 seconds before doing so!

wilzbach requested review from CyberShadow, MartinNowak and andralex as code owners April 13, 2018 12:20

wilzbach mentioned this pull request Apr 13, 2018

update contracts.dd to reflect DIP1009 #2339

Merged

wilzbach force-pushed the fix-raw-start branch from 28801cb to a881453 Compare April 13, 2018 12:25

wilzbach commented Apr 13, 2018

View reviewed changes

CyberShadow reviewed Apr 13, 2018

View reviewed changes

wilzbach force-pushed the fix-raw-start branch from a881453 to da59a98 Compare April 14, 2018 21:37

Fix building dlang.org from scratch

db41a6d

wilzbach force-pushed the fix-raw-start branch from da59a98 to db41a6d Compare April 14, 2018 21:46

wilzbach mentioned this pull request Apr 14, 2018

Only compile the failing spec tester example #2345

Closed

dlang-bot added Needs Rebase Needs Work stalled labels May 27, 2021

angelkennedy492 approved these changes Jan 20, 2023

View reviewed changes

LightBender closed this Oct 27, 2024


		Please see the [Ddoc fundamentals](https://wiki.dlang.org/Contributing_to_dlang.org).

		### Learn about the more Makefile targets and options

Uh oh!

Comments

Conversation

wilzbach commented Apr 13, 2018

Uh oh!

dlang-bot commented Apr 13, 2018

Bugzilla references

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyberShadow commented Apr 13, 2018

Uh oh!

zachthemystic commented Apr 14, 2018

Uh oh!

CyberShadow commented Apr 14, 2018

Uh oh!

zachthemystic commented Apr 14, 2018

Uh oh!

wilzbach commented Apr 14, 2018

Uh oh!

zachthemystic commented Apr 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants