Skip to content

Comments

[spec/function.dd] Add scope parameter section#2454

Merged
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:scope-param
Jun 18, 2020
Merged

[spec/function.dd] Add scope parameter section#2454
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:scope-param

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Aug 23, 2018

  • Tweak existing wording
  • Mention @safe & -dip1000 needed for enforcement

Update:

  • Split existing return ref example.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 23, 2018

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ntrel
Copy link
Contributor Author

ntrel commented Jun 16, 2020

@thewilsonator Sorry I forgot about this. Rebased! (At least I get CircleCI notifications now when my builds fail :-) ).

ntrel added 3 commits June 17, 2020 13:15
Mention unique allocation elision.
Also split return scope example.
Reparent `return scope` section headings.
Remove note about -dip1000 in return scope section as it is now
mentioned in the (earlier) scope parameter section.
@ntrel ntrel changed the title [spec] Add scope parameter caveats [spec/function.dd] Add scope parameter section Jun 17, 2020
@ntrel
Copy link
Contributor Author

ntrel commented Jun 17, 2020

The scope parameter changes were getting a bit big for the function parameter table, so I have moved them to their own section and split out an example from the return scope docs.

@dlang-bot dlang-bot merged commit 43b6100 into dlang:master Jun 18, 2020
@ntrel ntrel deleted the scope-param branch June 18, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants