Skip to content

Comments

[class.dd] Move Objective-C method specifics to subsection#2808

Merged
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:class-objc
Jun 3, 2020
Merged

[class.dd] Move Objective-C method specifics to subsection#2808
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:class-objc

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Jun 2, 2020

The Objective-C method specifics (added in #2540) make it hard to read the docs for people not interested in Objective-C linkage. This moves the details to a subsection.

Also:

  • Mention that member functions are also called methods (which is used in some places in class.dd already).
  • 2 minor tweaks to surrounding class docs.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, cc @jacob-carlborg

@jacob-carlborg
Copy link
Contributor

Fine by me.

@dlang-bot dlang-bot merged commit 4e85129 into dlang:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants