Skip to content

Comments

Remove outdated definition of FunctionLiteralBody#3003

Merged
maxhaton merged 1 commit intodlang:masterfrom
linkrope:patch-1
May 16, 2021
Merged

Remove outdated definition of FunctionLiteralBody#3003
maxhaton merged 1 commit intodlang:masterfrom
linkrope:patch-1

Conversation

@linkrope
Copy link
Contributor

Pull request #2339 added the grammar rule

FunctionLiteralBody:
    SpecifiedFunctionBody

to function.dd, but did not remove the outdated grammar rule

FunctionLiteralBody:
    BlockStatement
    FunctionContractsopt BodyStatement

from expression.dd. The BodyStatement is gone (dead link), so I propose to change the links to FunctionLiteralBody to point to function.dd.

(Alternatively, the grammar rule for FunctionLiteralBody could be moved from function.dd to expression.dd.)

Pull request #2339 added the grammar rule

    FunctionLiteralBody:
        SpecifiedFunctionBody

to function.dd, but did not remove the outdated grammar rule

    FunctionLiteralBody:
        BlockStatement
        FunctionContractsopt BodyStatement

from expression.dd. The BodyStatement is gone (dead link), so I propose to change the links to FunctionLiteralBody to point to function.dd.

(Alternatively, the grammar rule for FunctionLiteralBody could be moved from function.dd to expression.dd.)
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @linkrope! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@maxhaton maxhaton merged commit 51cb58c into dlang:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants