Remove outdated definition of FunctionLiteralBody#3003
Merged
maxhaton merged 1 commit intodlang:masterfrom May 16, 2021
linkrope:patch-1
Merged
Remove outdated definition of FunctionLiteralBody#3003maxhaton merged 1 commit intodlang:masterfrom linkrope:patch-1
maxhaton merged 1 commit intodlang:masterfrom
linkrope:patch-1
Conversation
Pull request #2339 added the grammar rule FunctionLiteralBody: SpecifiedFunctionBody to function.dd, but did not remove the outdated grammar rule FunctionLiteralBody: BlockStatement FunctionContractsopt BodyStatement from expression.dd. The BodyStatement is gone (dead link), so I propose to change the links to FunctionLiteralBody to point to function.dd. (Alternatively, the grammar rule for FunctionLiteralBody could be moved from function.dd to expression.dd.)
Contributor
|
Thanks for your pull request and interest in making D better, @linkrope! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
mdparker
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #2339 added the grammar rule
to function.dd, but did not remove the outdated grammar rule
from expression.dd. The BodyStatement is gone (dead link), so I propose to change the links to FunctionLiteralBody to point to function.dd.
(Alternatively, the grammar rule for FunctionLiteralBody could be moved from function.dd to expression.dd.)