changed 'alias y x' to 'alias x = y' throughout dlang.org#492
changed 'alias y x' to 'alias x = y' throughout dlang.org#492JinShil wants to merge 1 commit intodlang:masterfrom JinShil:patch-2
Conversation
expression.dd
Outdated
There was a problem hiding this comment.
This isn't valid. I think the old syntax will be deprecated as well. @9rnsr: Do you know if I'm right about the deprecation?
There was a problem hiding this comment.
Oops, I got a little carried away. Can I just fix it in my branch?
There was a problem hiding this comment.
@AndrejMitrovic I don't know that the old alias syntax will be deprecated. At least, currently new alias syntax does not cover all of old syntax features.
- New alias syntax cannot declare function type directly
alias int func(int);is OK, butalias fun = int(int);is not valid. - New alias syntax cannot declare function pointer or delegate type with
extern.
alias extern(C) int function() FP;is OK, butalias FP = extern(C) int function();is not accepted.
|
Done with my review. Thank you very much for doing this @JinShil! |
|
@AndrejMitrovic Thanks for the review. I believe I've fixed all errors. |
|
Thanks. Could you please squash the commits together? |
|
I'm sorry, but I'm new to this. Can you tell me how? |
And then mark the first commit as the one to pick, the others as "fixup", and change the first commit's message to something like I've done below: If you end up in a Vi interface like I did, hit the |
|
Thanks. Done. |
|
I'm seeing 8 commits now. |
|
Excellent, I'm seeing only 1 commit now. If all you want to do is edit its commit message, you can do: |
|
I totally screwed this up. I'll submit another pull request later. |

No description provided.