grammar/changelog for asm attributes#667
Merged
DmitryOlshansky merged 1 commit intodlang:masterfrom Nov 27, 2014
Merged
Conversation
MartinNowak
force-pushed
the
asmAttribute
branch
from
0000000 to
31cf8eb
Compare
There was a problem hiding this comment.
Sorry, but then why allow the attributes at all?
Member
Author
There was a problem hiding this comment.
So that the compiler knows how your asm code behaves, I added a reasoning to the changelog.
MartinNowak
force-pushed
the
asmAttribute
branch
from
31cf8eb to
266c9e9
Compare
MartinNowak
force-pushed
the
asmAttribute
branch
from
266c9e9 to
bc73d96
Compare
Member
Author
|
Would be nice to get this merged. |
Member
|
Can't auto-merge this on github. Rebase? |
MartinNowak
force-pushed
the
asmAttribute
branch
from
bc73d96 to
5f57667
Compare
Member
Author
|
Updated, I also change the wording in the changelog to emphasize why one can add attributes. |
Member
Author
|
Ping |
DmitryOlshansky
added a commit
that referenced
this pull request
Nov 27, 2014
grammar/changelog for asm attributes
Member
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.