[WIP] Translate _d_arraycatnTX to template by Vild · Pull Request #10064 · dlang/dmd

Vild · 2019-06-19T22:23:36Z

These patches will lower a ~ a to (S[][2] __cat2 = [arr1, arr1];) , _d_arraycatnTX(cast(S[][])__cat2).

JinShil · 2019-06-19T23:50:12Z

// This line will assert the compile:
//     dmd: dmd/backend/cod4.d:401: Assertion `cast(int)sz > 0' failed.
S[] arr3 = arr1 ~ arr1 ~ arr1;

@WalterBright Could you please lend your expertise to help us solve the backend assertion failure?

JinShil · 2019-06-20T00:09:23Z

So I guess I need to mark my static-array as a scope type,, but I could not find how to do that.

I believe you should be able to do that with Parameter fparam; fparam.storageClass |= STC.scope_

Though I'm not sure how to do that when all you have is an array of Expressions. I'll look into it.

Edit: Gah, you can't do that. You have to do it at the function declaration site. I guess I don't understand. Please clarify.

src/dmd/expressionsem.d

src/dmd/dinterpret.d

dlang-bot · 2019-06-30T23:43:24Z

Thanks for your pull request and interest in making D better, @Vild! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10064"

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

Without this the first argument turns into a `string` src/dmd/mars.d(2174): Error: function `dmd.mars.parseCommandLine.error(const(char)* format, const(char*) arg = null)` is not callable using argument types `(string, const(char)*)` Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

rainers · 2019-07-23T06:39:03Z

src/dmd/dinterpret.d

+
+                Expression ea = (*e.arguments)[0];
+
+                while (true)


You have used a simpler while(ea.isCastExp()) ea = ea.isCastExp().e1; elsewhere.

rainers · 2019-07-23T06:39:37Z

src/dmd/dinterpret.d

+                }
+
+                if (global.params.verbose)
+                    message("interpret  %s =>\n          %s", e.toChars(), e1.toChars());


Do not use message for your debug output, use versioned printf instead.

rainers · 2019-07-23T06:40:36Z

src/dmd/expressionsem.d

                exp.type = tb1next.arrayOf();
            L2elem:
-                if (tb2.ty == Tarray || tb2.ty == Tsarray)
+                if (tb2.ty != Tarray && tb2.ty != Tsarray)


Why can you completely invert the condition here?

rainers · 2019-07-23T06:42:27Z

src/dmd/expressionsem.d

-                result = exp.optimize(WANTvalue);
-                return;
+                e = exp.optimize(WANTvalue);
+                goto Lrewrite;


Can you place the rewriting into a (local) function instead of having to use goto?

rainers · 2019-07-23T06:45:01Z

src/dmd/mars.d

                    if (!flag)
                    {
-                        error("unknown JSON field `-Xi=%s`, expected one of " ~ jsonFieldNames, p + 4);
+                        error(cast(const(char)*)("unknown JSON field `-Xi=%s`, expected one of " ~ jsonFieldNames), p + 4);


I haven't looked closely at the actual rewrite, but if it needs this additional cast (probably concatenation moved from CT to RT) it will break quite some code,

RazvanN7 · 2021-12-16T13:55:27Z

Closing as @teodutu is taking care of this.

Vild mentioned this pull request Jun 19, 2019

Add templated _d_arraycatnTX with tests dlang/druntime#2648

Merged

Vild changed the title ~~Convert array cat hook~~ [WIP] Convert array cat hook Jun 19, 2019

jacob-carlborg reviewed Jun 20, 2019

View reviewed changes

src/dmd/expressionsem.d Show resolved Hide resolved

jacob-carlborg reviewed Jun 20, 2019

View reviewed changes

src/dmd/dinterpret.d Outdated Show resolved Hide resolved

Vild force-pushed the ConvertArrayCatHook branch from 16ef63e to 45e13d4 Compare June 25, 2019 16:59

Vild marked this pull request as ready for review June 30, 2019 23:43

Vild force-pushed the ConvertArrayCatHook branch from b6be734 to b0e932e Compare June 30, 2019 23:43

Vild changed the title ~~[WIP] Convert array cat hook~~ Convert array cat hook Jun 30, 2019

Vild changed the title ~~Convert array cat hook~~ Translate _d_arraycatnTX to template Jun 30, 2019

Vild force-pushed the ConvertArrayCatHook branch from b0e932e to bacbf8e Compare July 9, 2019 13:39

Vild added 6 commits July 22, 2019 03:11

Lower array concat to _d_arraycatnTX

809b270

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

Intercept and handle _d_arraycatnTX for CTFE

e6cd727

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

Implement check for _d_arraycatnTX in nogc.d

3994f7e

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

Remove backend code for _d_arraycatnTX

31d5882

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

Added symbol to hello-profile.d.trace.def

5e68666

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>

Vild force-pushed the ConvertArrayCatHook branch from bacbf8e to 0a24ab8 Compare July 22, 2019 01:11

Vild requested review from Geod24, MartinNowak, WalterBright and rainers as code owners July 22, 2019 01:11

rainers reviewed Jul 23, 2019

View reviewed changes

Vild changed the title ~~Translate _d_arraycatnTX to template~~ [WIP] Translate _d_arraycatnTX to template Jul 23, 2019

dlang-bot added the Review:WIP Work In Progress - not ready for review or pulling label Jul 23, 2019

dlang-bot added Review:Needs Rebase Review:Needs Work Review:stalled labels May 20, 2021

RazvanN7 closed this Dec 16, 2021

teodutu mentioned this pull request Oct 12, 2022

Translate _d_arraycatnTX to a template #14550

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

[WIP] Translate _d_arraycatnTX to template#10064

[WIP] Translate _d_arraycatnTX to template#10064
Vild wants to merge 6 commits intodlang:masterfrom
Vild:ConvertArrayCatHook

Vild commented Jun 19, 2019 •

edited

Loading

Uh oh!

JinShil commented Jun 19, 2019

Uh oh!

JinShil commented Jun 20, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

dlang-bot commented Jun 30, 2019 •

edited

Loading

Uh oh!

rainers Jul 23, 2019

Uh oh!

rainers Jul 23, 2019

Uh oh!

rainers Jul 23, 2019

Uh oh!

rainers Jul 23, 2019

Uh oh!

rainers Jul 23, 2019

Uh oh!

RazvanN7 commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Comments

Conversation

Vild commented Jun 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JinShil commented Jun 19, 2019

Uh oh!

JinShil commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlang-bot commented Jun 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bugzilla references

Testing this PR locally

Uh oh!

rainers Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

rainers Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

rainers Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

rainers Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

rainers Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

RazvanN7 commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Vild commented Jun 19, 2019 •

edited

Loading

JinShil commented Jun 20, 2019 •

edited

Loading

dlang-bot commented Jun 30, 2019 •

edited

Loading