add restrictiveshared preview flags (hidden).#10117
add restrictiveshared preview flags (hidden).#10117thewilsonator wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10117" |
wilzbach
left a comment
There was a problem hiding this comment.
Can't we add the flag when there is an actual PR for it?
|
We've never been calling it restrictive shared, more like atomic shared. |
WalterBright
left a comment
There was a problem hiding this comment.
I'd call it atomicshared or just atomic.
There'll be likely several PRs for it, as one big one will be too big to review. Progress is currently stalled by nobody willing to look at #10097 At this rate, it'll never happen :-( |
You've not been calling it restrictive. Possibly because the plan you have is not the plan the rest of the community has which has little to do with atomics other than as a basic building block (although it was noted that I don't really care what the preview flag is called provided it is clearly about shared, I didn't go with "shared", because we already have "newshared", "nothorriblybrokenshared" are all fine with me, but I went with "restrictiveshared" because shared will become more restrictive (as in less operations are allowed on it). You can paint the bikeshed any colour you like, so long as its "shared". |
Definitely.
It'll be a miracle if one PR manages to get the semantics correct in one shot irrespective of its size or difficulty to review.
Thats a backend PR, practically no-one is qualified to review those. Also, thats for what you want to do. What the rest of us are doing is not thus handicapped.
Oh, it will. Just not necessarily what you had in mind. |
shared and atomic intrinsics are not related tasks. |
|
I need this compiler switch, can we please merge it? |
|
@WalterBright #10142 could a remove the static if, if this is merged. |
|
Superseded by #10142 |
This is currently hidden because it currently induces no change. It serves to section off changes related to shared and thread safety.