Fix calls to GC.addRange and GC.removeRange to be const-correct in root/rmem.d#10241
Fix calls to GC.addRange and GC.removeRange to be const-correct in root/rmem.d#10241JinShil wants to merge 1 commit intodlang:masterfrom JinShil:fix_rmem
GC.addRange and GC.removeRange to be const-correct in root/rmem.d#10241Conversation
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10241" |
|
See also dlang/druntime#2704 (review) |
|
I think this should not be necessary, see dlang/druntime#2706 (comment) |
|
Closing. There are some const-ness problems in the GC interface and implementations, but fixing that will have to be a different PR. |
In support of dlang/druntime#2706
The interface to
GC.addRangeandGC.removeRangeis notconsthttps://github.com/dlang/druntime/blob/a370406fae72602ab2e0fe632d7a70a71da79267/src/gc/proxy.d#L228-L231
https://github.com/dlang/druntime/blob/a370406fae72602ab2e0fe632d7a70a71da79267/src/gc/proxy.d#L238-L241
https://github.com/dlang/druntime/blob/a370406fae72602ab2e0fe632d7a70a71da79267/src/gc/impl/proto/gc.d#L27-L28
https://github.com/dlang/druntime/blob/a370406fae72602ab2e0fe632d7a70a71da79267/src/gc/impl/proto/gc.d#L202
https://github.com/dlang/druntime/blob/a370406fae72602ab2e0fe632d7a70a71da79267/src/gc/impl/proto/gc.d#L207