remove getLabel() and labelToBlock() as dead code#10403
Merged
thewilsonator merged 1 commit intodlang:masterfrom Dec 20, 2019
Merged
remove getLabel() and labelToBlock() as dead code#10403thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
WalterBright
added
Review:Easy Review
Severity:Refactoring
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10403" |
Member
Author
|
Ah, I thought #10322 had been pulled. |
thewilsonator
approved these changes
Sep 9, 2019
Contributor
or not. |
Member
Author
|
Blocked by #10322 |
WalterBright
force-pushed
the
rmGetLabel
branch
from
da62af8 to
3190396
Compare
Contributor
|
There was a network failure on the doc tester. Please push and re-add auto-merge |
WalterBright
force-pushed
the
rmGetLabel
branch
from
3190396 to
75f3da3
Compare
Contributor
|
The failures are still there. |
Member
Author
|
Yah, looks like all unrelated networking problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.