DScanner: Enable warnings for unused parameters ...

[MoonlightSentinel]

... and fix access.d, astbase, todt.d, traits.d and typesem.d for starters. This obviously requires quite a blacklist right now but still covers about 2/3 of all source files.

Bonus: This revealed that the documentation of checkAccess did not match its implementation.

CC @wilzbach

[dlang-bot]

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10700"

[rainers]

Some of the changes are good (e.g. adding module declarations), but I'm not so sure about enabling warnings about unused parameters. Removing them also reduces information provided by intellisense or documentation.

[MoonlightSentinel]

Some of the changes are good (e.g. adding module declarations), but I'm not so sure about enabling warnings about unused parameters. Removing them also reduces information provided by intellisense or documentation.

I think checking for unused parameters should be done because it can reveal violations of a functions contract/documentation (see e.g. checkAccess). But DScanner should have something like Javas SuppressWarnings("unused") to mark parameters that are reserved for overriding methods.

Anyway, i would be fine with splitting this into different PRs for local/parameters. But limiting this check to local variables is currently not possible (because it was introduced after dlang-community/D-Scanner#786 appeared.

[MoonlightSentinel]

PR to enable checks for unused variables only #10714

[MoonlightSentinel]

Closing until D-Scanner provides some means to allow unused parameters for documentation purposes.