Skip to content

[stable] Fix C++ header regression#10786

Merged
dlang-bot merged 1 commit intodlang:stablefrom
kinke:patch-1
Feb 14, 2020
Merged

[stable] Fix C++ header regression#10786
dlang-bot merged 1 commit intodlang:stablefrom
kinke:patch-1

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Feb 14, 2020

Introduced by #10745.

@kinke kinke requested a review from ibuclaw as a code owner February 14, 2020 18:15
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10786"

kinke added a commit to kinke/ldc that referenced this pull request Feb 14, 2020
kinke added a commit to ldc-developers/ldc that referenced this pull request Feb 14, 2020
@dlang-bot dlang-bot merged commit 137b3fb into dlang:stable Feb 14, 2020
@kinke kinke deleted the patch-1 branch February 14, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants