Skip to content

[stable] Follow-up on #9221#10864

Merged
dlang-bot merged 1 commit intodlang:stablefrom
kinke:needmoduleinfo
Mar 10, 2020
Merged

[stable] Follow-up on #9221#10864
dlang-bot merged 1 commit intodlang:stablefrom
kinke:needmoduleinfo

Conversation

@kinke
Copy link
Copy Markdown
Contributor

@kinke kinke commented Mar 4, 2020

No description provided.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#10864"

@thewilsonator thewilsonator requested a review from RazvanN7 March 5, 2020 00:24
@kinke
Copy link
Copy Markdown
Contributor Author

kinke commented Mar 9, 2020

This should really make it into v2.091.0 final; do you guys need some explanations wrt. this?

@dlang-bot dlang-bot merged commit 345fac2 into dlang:stable Mar 10, 2020
@kinke kinke deleted the needmoduleinfo branch March 10, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants