Skip to content

Fix Issue 20130 - ICE when casting from string to other array type du…#10941

Merged
dlang-bot merged 1 commit intodlang:stablefrom
BorisCarvajal:fix20130
Mar 19, 2020
Merged

Fix Issue 20130 - ICE when casting from string to other array type du…#10941
dlang-bot merged 1 commit intodlang:stablefrom
BorisCarvajal:fix20130

Conversation

@BorisCarvajal
Copy link
Copy Markdown
Member

…e to __ArrayCast not being written

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20130 regression ICE when casting from string to other array type due to __ArrayCast not being written

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#10941"

@dlang-bot dlang-bot merged commit ff7c9ef into dlang:stable Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants