Skip to content

Prefer the host dmd to compile the test runner#10950

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:prefer-host
Mar 21, 2020
Merged

Prefer the host dmd to compile the test runner#10950
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:prefer-host

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

This ensures that all tests are run properly and potential failures (e.g. because of faulty codegen) occur in small snippets instead of the test runner itself.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10950"

This ensures that all tests are run properly and potential failures
(e.g. because of faulty codegen) occur in small snippets instead of
the test runner itself.
@dlang-bot dlang-bot merged commit c8c4ce3 into dlang:master Mar 21, 2020
$(DMD) -conf= $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -unittest -run $<
$(DMD) -conf= $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -od$(RESULTS_DIR) -of$@ $<
$(D) $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -unittest -run $<
$(D) $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -od$(RESULTS_DIR) -of$@ $<
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a slightly longer name here ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or not, since it was merged just now.

Copy link
Copy Markdown
Contributor Author

@MoonlightSentinel MoonlightSentinel Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll fix this in another PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #10977

@MoonlightSentinel MoonlightSentinel deleted the prefer-host branch March 21, 2020 13:52
MoonlightSentinel added a commit to MoonlightSentinel/dmd that referenced this pull request Mar 29, 2020
dlang-bot added a commit that referenced this pull request Mar 29, 2020
test/Makefile: Address feedback for #10950
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants