Prefer the host dmd to compile the test runner#10950
Conversation
b91f31c to
b31b189
Compare
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#10950" |
b31b189 to
56f5b66
Compare
This ensures that all tests are run properly and potential failures (e.g. because of faulty codegen) occur in small snippets instead of the test runner itself.
56f5b66 to
17a0225
Compare
| $(DMD) -conf= $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -unittest -run $< | ||
| $(DMD) -conf= $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -od$(RESULTS_DIR) -of$@ $< | ||
| $(D) $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -unittest -run $< | ||
| $(D) $(MODEL_FLAG) $(PIC_FLAG) -g -lowmem -i -Itools -version=NoMain -od$(RESULTS_DIR) -of$@ $< |
There was a problem hiding this comment.
Maybe use a slightly longer name here ?
There was a problem hiding this comment.
Or not, since it was merged just now.
There was a problem hiding this comment.
Sure, I'll fix this in another PR.
test/Makefile: Address feedback for #10950 merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This ensures that all tests are run properly and potential failures (e.g. because of faulty codegen) occur in small snippets instead of the test runner itself.