Skip to content

Add -preview=in information to the changelog#11003

Merged
dlang-bot merged 2 commits intodlang:masterfrom
atilaneves:changelog-preview-in
Apr 10, 2020
Merged

Add -preview=in information to the changelog#11003
dlang-bot merged 2 commits intodlang:masterfrom
atilaneves:changelog-preview-in

Conversation

@atilaneves
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @atilaneves! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11003"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lacks any context as to why the change was made. An user, on reading this, won't understand why [s]he needs to use it, or what it brings him/her. And we should not assume the user is aware of this switch's connection to DIP1000, either.

@atilaneves atilaneves force-pushed the changelog-preview-in branch from 04f8431 to b767c24 Compare April 6, 2020 10:25
@atilaneves
Copy link
Contributor Author

@Geod24 Good to go?

@atilaneves atilaneves force-pushed the changelog-preview-in branch from b767c24 to 08011be Compare April 10, 2020 12:31
@dlang-bot dlang-bot merged commit aa6ddca into dlang:master Apr 10, 2020
@atilaneves atilaneves deleted the changelog-preview-in branch April 15, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants